expand Manifest with pool_size and client_timeout #584

Turnalek · 2025-09-18T22:34:02Z

Summary & Motivation (Problem vs. Solution)

Expands the Manifest format and it's handling qos-client with pool-size and client-timeout parameters.

pool-size allows us to specify the number of internal USOCK/VSOCK connections for concurrency without impedeing app params list. It gets translated to an env var for the app.

client-timeout can now be used to specify the timeout for calls done by SocketClient inside the enclave.

There's also a minor refactor moving away from TimeVal to Duration in around SocketClient timeout type and params.

NOTE: hosts and proxy still need the timeout value handled explicitly of course, but that's out of scope for this PR.

WARNING: Please do NOT merge yet, as I want to test with a deploy in preprod first. Reviews are welcome.

How I Tested These Changes

Locally so far

and use it in Reaper, also expand qos_client with the cli argument for it

src/qos_core/src/protocol/services/boot.rs

src/integration/src/lib.rs

src/integration/tests/enclave_app_client_socket_stress.rs

src/integration/tests/reaper.rs

src/integration/tests/simple_socket_stress.rs

emostov · 2025-09-19T17:19:36Z

Generally looks good just a few comments

also fix small nits

…meout

r-n-o

Awesome! Some minor minor suggestions below (feel free to punt / address in a followup PR!); flawless diff otherwise 👑

r-n-o · 2025-09-24T21:00:11Z

src/integration/tests/reaper.rs

 	let enclave_pool =
-		StreamPool::new(SocketAddress::new_unix(&usock), 1).unwrap();
+		StreamPool::single(SocketAddress::new_unix(&usock)).unwrap();


r-n-o · 2025-09-24T21:03:35Z

src/qos_core/src/protocol/processor.rs

+/// Initial client timeout for the processor until the Manifest says otherwise
+pub const INITIAL_CLIENT_TIMEOUT: Duration = Duration::from_secs(5);


Where is the "until the Manifest says otherwise" part? Maybe worth an extra bit of comment? (I think a simple "see reaper.rs" could be fine; that's where set_client_timeout is called from)

src/qos_core/src/reaper.rs

r-n-o · 2025-09-24T21:06:55Z

src/qos_core/src/reaper.rs

-fn get_pool_size_from_pivot_args(handles: &Handles) -> (bool, Option<u32>) {
-	if let Ok(envelope) = handles.get_manifest_envelope() {
-		(true, extract_pool_size_arg(&envelope.manifest.pivot.args))
-	} else {
-		(false, None)
-	}
-}
-
-// find the u32 value of --pool-size argument passed to the pivot if present
-fn extract_pool_size_arg(args: &[String]) -> Option<u32> {
-	if let Some((i, _)) =
-		args.iter().enumerate().find(|(_, a)| *a == "--pool-size")
-	{
-		if let Some(pool_size_str) = args.get(i + 1) {
-			match pool_size_str.parse::<u32>() {
-				Ok(pool_size) => Some(pool_size),
-				Err(_) => None,
-			}
-		} else {
-			None
-		}
-	} else {
-		None
-	}
-}


emostov · 2025-09-24T21:44:57Z

src/qos_core/src/protocol/processor.rs

-	/// Sets the client timeout value for the `app_client`
+	/// Sets the client timeout value for the `app_client`, maximum allowed value is `u16::MAX` milliseconds
 	pub fn set_client_timeout(&mut self, timeout: Duration) {
+		assert!(timeout.as_millis() < u16::MAX.into(), "client timeout > 65s");


I actually think this will likely be too restrictive (e.g. zk proof gen). But we can cross that bridge when we get there

Turnalek added 3 commits September 18, 2025 15:30

qos_core: add pool_size field to PivotConfig in the Manifest

b22cd5c

and use it in Reaper, also expand qos_client with the cli argument for it

qos_core: use Manifest.pool_size instead of pivot args

8f5957d

qos_core: add client_timeout to Manifest

ff0dd77

Turnalek requested a review from a team as a code owner September 18, 2025 22:34

Turnalek requested review from emostov and r-n-o September 18, 2025 22:34

emostov reviewed Sep 18, 2025

View reviewed changes

src/qos_core/src/protocol/services/boot.rs Show resolved Hide resolved