Skip to content

fix: pushing images (#200)#204

Merged
tkrop merged 1 commit into
mainfrom
images-push
May 18, 2026
Merged

fix: pushing images (#200)#204
tkrop merged 1 commit into
mainfrom
images-push

Conversation

@tkrop
Copy link
Copy Markdown
Owner

@tkrop tkrop commented May 18, 2026

Description

This pull request fixes the pushing of images. In #200 we incidentally had integrated the additional --tag=image:latest addition when pushing images, which is not always allowed. This is only a tag that we want to use in the local build.

Related Issue(s)

fixes #204.

Testing

Run make test, since the code is highly unit tested.

Checklist

  • I have reviewed and tested the changes thoroughly.
  • I have added appropriate documentation to the code for clarity.
  • I have communicated the consequences of the updates to customers.

Signed-off-by: Tronje Krop tronje.krop@jactors.de

Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
@tkrop tkrop self-assigned this May 18, 2026
@tkrop tkrop changed the title feat: pushing images (#204) fix: pushing images (#204) May 18, 2026
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 18, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage diff coverage (90.00%)

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (194f3b7) 416 416 100.00%
Head commit (e49c8ee) 416 (+0) 416 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#204) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@tkrop tkrop changed the title fix: pushing images (#204) fix: pushing images (#200) May 18, 2026
@tkrop tkrop marked this pull request as ready for review May 18, 2026 14:26
@tkrop tkrop merged commit d869116 into main May 18, 2026
13 of 14 checks passed
@tkrop tkrop deleted the images-push branch May 18, 2026 14:26
@tkrop tkrop mentioned this pull request May 18, 2026
3 tasks
tkrop added a commit that referenced this pull request May 18, 2026
Signed-off-by: Tronje Krop <tronje.krop@jactors.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant