feat: Add --include argument to the model-generate script
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a `--tbl-obj` / `-o` argument to the `model-generate` script * Generates table files for the table(s) specified by the new arg * Tests and documents new functionality * Updates pytest to allow passing more args to the `run_generator` fixture
Owner
|
Awesome! Great idea. Happy to merge this. I hear you on the naming, but I don't mind the I am ok with either. So let me know if you like the Also left one feedback thing in the review Thanks again! |
tkutcher
reviewed
Jun 15, 2021
Contributor
Author
|
Yea, |
mklaber
commented
Jun 15, 2021
Owner
|
Awesome! Thanks again. I will merge and release soon. |
tkutcher
approved these changes
Jun 15, 2021
tkutcher
changed the title
--tbl-obj argument to the model-generate script--include argument to the model-generate script
tkutcher
pushed a commit
that referenced
this pull request
Jun 15, 2021
tkutcher
pushed a commit
that referenced
this pull request
Jun 15, 2021
mklaber
added a commit
to heylohousing/quickbase-client
that referenced
this pull request
Jun 18, 2021
Though tkutcher#40 cuts down on the number of files generated, it did not cut down on the number of times fields for tables were requested. This commit moves the "skip" logic to before the `get_fields_for_table` call. (It also adds pytest-mock in order to test the change.)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a user with a large QB app who is writing an integration script for just a couple of tables in my app, it doesn't make sense to generate class files for all of the tables in my app. This PR allows users to generate files for only a subset of tables via a new
--includeargument (that can be specified multiple times to allow multiple tables).An ancillary benefit is to minimise the risk of re-running the script on an existing client (as described in #29). A user could decide to update just a single table if they really need the changes to that table and don't want to risk updating the whole app.
--include/-iargument to themodel-generatescriptrun_generatorfixtureChecklist:
devbranch