Conversation
Two issues caused the derive pipeline to fail on edge claim conflicts: 1. The relation extractor's subsumption check compared (leaf_relation_id, way_id, direction) tuples across roots. When one root used a flat structure (e.g. I-22 relation 111060) and another organized the same ways into child relations (relation 5611155), the leaf IDs differed even though the ways and directions matched. The subset check now compares (way_id, direction) only, and ignores blank-direction members when the root has directional siblings — those blanks are already dropped downstream by filter_route_groups. 2. The edge claim validator in relation_corridors.rs treated any shared edge between two corridor drafts as a fatal conflict. Two corridors from the same root relation but different directions (e.g. I-65 north and south sharing a short physical segment) are a normal real-world situation. The validator now allows shared edges within the same root. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Public Contract Impact
Licensing / Attribution Impact
Validation