Fixed wrong cache directory name #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
approved these changes
Jan 6, 2022
Contributor
MasterOdin
left a comment
MasterOdin
left a comment
There was a problem hiding this comment.
Merging this onto the CI changes in #76 verified that this fixes the segfault on macos and linux: https://github.com/tldr-pages/tldr-c-client/runs/4727718920?check_suite_focus=true
Per the review comment #59 (comment), this seems like it fixes the problem in the best way, that we now properly extract the zip into the ~/.tdr directory.
|
Hi all! This thread has not had any recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
I added two new
#defines calledTLDR_ZIP_DIRandTLDR_ZIP_DIR_LEN, used them inupdate_localdband changedTLDR_DIRback.Why the change?
While the directory in the ZIP has this different name, we assume the name of the extracted directory, for example in
TLDR_EXT, to betldr. This is what caused the segfaults.How can this be tested?
Try reproducing #71 or #74.