Add some more basic integration tests to CI #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenvoke
approved these changes
Jan 6, 2022
Member
owenvoke
left a comment
owenvoke
left a comment
There was a problem hiding this comment.
LGTM after the referenced PR is merged.
|
Hi all! This thread has not had any recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds two new "integration tests" to the CI workflow to help test basic CLI usage.
Why the change?
As shown in #71, a segfault slipped into the codebase. Adding this helps validate the behavior of the client. This acts as a small starting point to act as a place to prevent a regression on merging #75.
How can this be tested?
Run CI tests
Other notes
This should be merged after merging #75. A successful run of this action on top of #75 can be seen here: https://github.com/tldr-pages/tldr-c-client/actions/runs/1663299468