-
-
Notifications
You must be signed in to change notification settings - Fork 49
More descriptive errors #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please adjust your editor settings to keep the current formatting. |
|
Oh, sorry about that, will fix |
|
@Leandros should be fixed now |
|
Great. Looks good. One tiny improvement and it's ready for the merge. It's better to use |
|
Good idea, should be fixed now. @Leandros |
|
You missed the |
|
Got it! And I checked a few commands and it seems that this type of situation is indeed considered "failure" |
|
I can cite other examples if you'd like |
|
Please merge the current master thread into your branch, it'll run the travis build. And you should notice the bug in your code, since it won't compile. |
|
Is it all good now? |
|
Yes. Build passed. Looks good! Merged! |
|
Thanks! 👍 |
Added the following error if no args are passed in:
And the following message if the wrong args are passed in:
fixes #7 #8
Let me know what you guys think 😄