docket: bind the specific paths we want to serve#313
Merged
Fang- merged 1 commit intorelease-410from Feb 28, 2025
Merged
Conversation
Docket binds root, so it catches all requests not handled elsewhere. It also binds `/apps`, so it can continue serving app contents after root gets re-bound by someone else. However, docket also serves `/session.js` (deprecated in favor of `/~/host` and/or `/~/name` but still in use in the wild) and `/docket/upload`. To make sure that those continue functioning if root ever gets re-bound elsewhere, we now explicitly bind `/session` and `/docket` to docket.
jamesacklin
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docket binds root, so it catches all requests not handled elsewhere. It also binds
/apps, so it can continue serving app contents after root gets re-bound by someone else.However, docket also serves
/session.js(deprecated in favor of/~/hostand/or/~/namebut still in use in the wild) and/docket/upload.To make sure that those continue functioning if root ever gets re-bound elsewhere, we now explicitly bind
/sessionand/docketto docket.