Moving Scanner-Core dependency from scanner-core 5.5.0 to 6.2.3 and fix deserialization issues #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix deserialization issues Version: - Moving Scanner-Core dependency from scanner-core 5.5.0 to 6.2.3 Fixes: 1. Add Jackson deserialization support to ScanResult - Add @JsonCreator annotation to private constructor - Add @JsonProperty annotations for all constructor parameters - Map 'resultStatus' JSON field to 'jobStatus' Java field - Fixes MongoDB deserialization via MongoJack 2. Fix Javadoc compilation error in IPersistenceProvider - Remove @param limit documentation for non-existent parameter 3. Implement missing methods in DummyPersistenceProvider - Add getScanResultsByTarget() returning empty list - Add getScanResultById() returning null - Fixes test compilation after interface updates
ic0ns
approved these changes
Oct 28, 2025
Member
|
Why does this contain duplicate changes with #61 ? I reviewed that before this was merged and posted comments there which also affect this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving Scanner-Core dependency from scanner-core 5.5.0 to 6.2.3 and fix deserialization issues
Version:
Fixes:
Add Jackson deserialization support to ScanResult
Fix Javadoc compilation error in IPersistenceProvider
Implement missing methods in DummyPersistenceProvider