Delegate modification #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ic0ns
reviewed
Jun 26, 2017
Contributor
ic0ns
left a comment
ic0ns
left a comment
There was a problem hiding this comment.
You forgot to add the BigIntegerInteractiveModification to the Serializable classes in the VariableModification class.
Please make sure that the Class is Serializable with JAXB and that it can be integrated into TLS-Attacker WorkflowTraces
| return new BigIntegerInteractiveModification(modification); | ||
| } | ||
|
|
||
| public static synchronized List<VariableModification<BigInteger>> modificationsFromFile() { |
Contributor
There was a problem hiding this comment.
This file is not correctly formated (probably whitespaces). Please run mvn formatter:format
| */ | ||
| @XmlRootElement | ||
| @XmlType(propOrder = { "interactive", "modificationFilter", "postModification" }) | ||
| public class BigIntegerInteractiveModification extends VariableModification<BigInteger> { |
Contributor
There was a problem hiding this comment.
The property "interactive" does not exist
Also, new workflow to specify an interactive modification. Again, this is probably something that should be discussed; my idea of a sensible compromise might differ from yours.
Contributor
Author
|
If I understand correctly, my latest push should have automagically appeared here, not sure why it didn't... Do I need to open a new pull request? Edit: Okay, apparently I just wasn't patient enough. |
…e and not every time get Value is called
ic0ns
approved these changes
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample implementation for BigInteger. Delegate-style, since the interactive modification would be useless in a GUI project if one could not inject a custom interaction. This obv opens the door to abuse this as the go-to modification, so there might be some room/need for discussion here.