Fix serialization issues in RatingInfluencers and Recommendations #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made RatingInfluencer and Recommendation classes implement Serializable - Made PropertyResultRatingInfluencer and PropertyResultRecommendation implement Serializable - Made AnalyzedProperty and AnalyzedPropertyCategory interfaces extend Serializable - Added SerializationTest to verify serialization works correctly This fixes SpotBugs warnings about non-transient non-serializable fields in serializable classes.
# Conflicts: # src/main/java/de/rub/nds/scanner/core/report/rating/PropertyResultRatingInfluencer.java # src/test/java/de/rub/nds/scanner/core/report/rating/SerializationTest.java
TrueSkrillor
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
RatingInfluencerandRecommendationclasses implementSerializablePropertyResultRatingInfluencerandPropertyResultRecommendationimplementSerializableAnalyzedPropertyandAnalyzedPropertyCategoryinterfaces extendSerializableSerializationTestto verify that bothRatingInfluencersandRecommendationscan be properly serialized and deserializedTest plan