Conversation
align personal branch with fronting server fixes.
|
@kaduk -- you may want to take a look to the proposed changes. |
kaduk
left a comment
kaduk
left a comment
There was a problem hiding this comment.
Generally looks fine, though the added paragraph in the security considerations section should probably be tweaked a bit more.
|
|
||
| In the future, it might be possible to assume that a large fraction of TLS handshakes | ||
| use SNI encryption. If that was the case, the detection of SNI encryption would | ||
| use SNI encryption. If that were the case, the detection of SNI encryption would |
There was a problem hiding this comment.
My understanding is that both "was" and "were" are acceptable usage here.
There was a problem hiding this comment.
I don't know for English, but in French there are subtle differences between the two. "If it was true, ..." would imply "... but it is not", while "if it were true" would leave open the possibility that it may or may not be. So I went with Barry's suggestion. But what do I know?
draft-ietf-tls-sni-encryption.md
Outdated
There was a problem hiding this comment.
We do discuss this topic elsewhere in the document, so it's not out of place to mention it again here. But the rhetoric does not flow very well, with "simultaneously" only mentioning one thing it does and not also the (desired) primary purpose to balance it. There's also not much of a transition from the previous paragraph, though in this style of writing there may not need to be one.
There was a problem hiding this comment.
Yes. I copied Mike's sentence, but it might be better to just point to the section that discusses the issue.
There was a problem hiding this comment.
Please check the new version.
chris-wood
left a comment
chris-wood
left a comment
There was a problem hiding this comment.
LGTM with some editorial nits. Thanks, @huitema!
Commiting Chris' suggestion. Co-Authored-By: Christopher Wood <caw@heapingbits.net>
Co-Authored-By: Christopher Wood <caw@heapingbits.net>
Co-Authored-By: Christopher Wood <caw@heapingbits.net>
Co-Authored-By: Christopher Wood <caw@heapingbits.net>
3 participants
This PR incorporates the feedback during IETF last call from Mike Bishop (issue #32), Meral Shirazipour (issue #33) and Barry Leiba (Issue #34), with only a few deltas:
Some of the issues were already fixed in PR Fix fronting spoofing ref #30, Fixing the fronting server spoofing section.
Not applying Meral's proposal to change "colocated" to "collocated", as "colocated" is established industry usage
Not applying Barry's suggestion to replace "floundered" by "foundered", as "floundered" is closer to intended meaning.