Skip to content

refactor and bugfix for printing#70

Merged
tmck-code merged 4 commits into
masterfrom
refactor-arg
Nov 29, 2024
Merged

refactor and bugfix for printing#70
tmck-code merged 4 commits into
masterfrom
refactor-arg

Conversation

@tmck-code
Copy link
Copy Markdown
Owner

@tmck-code tmck-code commented Nov 29, 2024

This is a developer-focused quality of life PR, aimed to reduce the ever growing list of params used by the print functions.

There is no noticeable speed impact from this change 🎉

Changes

  • boxCharacters -> boxChars
  • pass the Args struct to print functions
  • fix double-printing bug in no-bubble mode

instead of unpacking it and ending up with a _lot_ of params
where the line is printing twice
@tmck-code tmck-code changed the title pass the args struct to functions refactor and bugfix for printing Nov 29, 2024
@tmck-code tmck-code merged commit 847580d into master Nov 29, 2024
@tmck-code tmck-code deleted the refactor-arg branch November 29, 2024 07:43
@tmck-code tmck-code added the code quality Good for dev, little/no impact to users label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Good for dev, little/no impact to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant