Fix compile error due to more strict function argument syntax in C23#100
Merged
tmm1 merged 1 commit intotmm1:masterfrom May 13, 2025
Merged
Fix compile error due to more strict function argument syntax in C23#100tmm1 merged 1 commit intotmm1:masterfrom
tmm1 merged 1 commit intotmm1:masterfrom
Conversation
nullchristo
changed the title
nullchristo
commented
May 13, 2025
| #ifdef __FreeBSD__ | ||
| #define PLATFORM_FREEBSD | ||
| #elif __OpenBSD__ | ||
| #elif defined __OpenBSD__ |
Contributor
Author
There was a problem hiding this comment.
Quiets a compile warning over OpenBSD not existing
nullchristo
commented
May 13, 2025
| } else if (rbtracer.num > 0) { | ||
| // tracing only specific methods | ||
| int i, n; | ||
| unsigned int i, n; |
Contributor
Author
There was a problem hiding this comment.
Quiets a compile warning over comparing signed/unsigned ints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into a build issue when trying to install this gem after compiling Ruby with GCC 15, which defaults to the C23 standard.
C23 is more strict about functions without arguments actually having no arguments.
The
rb_data_type_tstruct expects a thedmarkfunction to have a singlevoid*arg, so I updated the signature of therb_gc_markfunction.