Skip to content

feature/news-carousel-component#9

Merged
tmsm1999 merged 5 commits intodevelopfrom
feature/news-carousel-component-view
Jan 17, 2023
Merged

feature/news-carousel-component#9
tmsm1999 merged 5 commits intodevelopfrom
feature/news-carousel-component-view

Conversation

@tmsm1999
Copy link
Copy Markdown
Owner

There are things from the other branch that I need here. Should we rethink branches and how we handle them?

Missing:

  • Team colours enum
  • Add fonts we are using to Fonts enum
  • Position in driver mocks?

@tmsm1999 tmsm1999 changed the title Created News Carousel Component feature/news-carousel-component Jan 14, 2023
Comment thread iOS/Slipstream_iOS/ViewModel/NewsCarouselComponentViewModel.swift Outdated
Comment thread iOS/Slipstream_iOS/ViewModel/NewsCarouselComponentViewModel.swift Outdated

import Foundation

protocol NewsCarouselComponentRepresentable {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be NewsCarouselCellRepresentable? 🤔

@tmsm1999 tmsm1999 linked an issue Jan 16, 2023 that may be closed by this pull request
@tmsm1999 tmsm1999 self-assigned this Jan 16, 2023
@tmsm1999 tmsm1999 force-pushed the feature/news-carousel-component-view branch from 50c01ee to 45a603b Compare January 16, 2023 11:09
Comment thread Shared/Styles/Fonts.swift Outdated
Comment thread Shared/Styles/Stylers/ConstructorStyler.swift Outdated
Comment thread iOS/Slipstream_iOS/Views/NewsCarouselComponentView.swift Outdated
Comment thread Shared/Styles/Stylers/ConstructorStyler.swift Outdated
Comment thread Shared/Styles/Colors.swift
@tmsm1999 tmsm1999 merged commit bf923a9 into develop Jan 17, 2023
@tmsm1999 tmsm1999 deleted the feature/news-carousel-component-view branch January 17, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

DriverConstructorCarouselComponentView

2 participants