Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the remaining typing cleanup plan in one pass:
chart_engine/builder.py)inspect_pptx.py)chart_engine/overlay_*.py)Changes
1) Builder pass
clean_slides/chart_engine/builder.pyAnyusage from this moduleslide_add_chart(...)shape_chart(...)chart_part_name(...)set_chart_has_legend(...)chart_series(...)chart_first_plot(...)set_plot_has_data_labels(...)plot_data_labels(...)shape_xml_element(...)+ typed parent protocol2) Inspect pass
clean_slides/inspect_pptx.pyAnyimport/alias for XML element typingXmlElementalias fromclean_slides/xml_helpers.py3) Overlay pass
clean_slides/chart_engine/overlay_bar.pyclean_slides/chart_engine/overlay_bar_legend.pyclean_slides/chart_engine/overlay_bar_segments.pyclean_slides/chart_engine/overlay_bar_totals_categories.pyclean_slides/chart_engine/overlay_waterfall.pyclean_slides/chart_engine/overlay_waterfall_connectors.pyclean_slides/chart_engine/overlay_waterfall_labels.pyclean_slides/chart_engine/overlay_waterfall_data_labels.pyAcross these modules:
Anyusageobject+ explicit protocol castsoverlay_waterfall_data_labels.py:_chartSpaceprobing withchart_xml_space(...)AnyXML nodes with_XmlElementLikeprotocol-based castsPlan completion
For targeted modules from the plan:
clean_slides/chart_engine/builder.py: ✅ noAnyclean_slides/inspect_pptx.py: ✅ no localAnyclean_slides/chart_engine/overlay_*.py: ✅ noAnyValidation
.venv/bin/ruff check clean_slides tests.venv/bin/pyright.venv/bin/pytest -q.venv/bin/pre-commit run --all-filesAll green locally.