support moving windows to other sessions #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 77.65%@@ master #10 diff @@
==========================================
Files 8 8
Lines 791 792 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 611 615 +4
+ Misses 180 177 -3
Partials 0 0
|
libtmux/window.py
Outdated
| :type target_window: string | ||
| to, default: empty string | ||
| :type destination: string | ||
| :param session: the ``target sesion`` or index to move the |
Contributor
Author
|
Typo corrected |
Member
|
Looks good to me. Do you need this in a project you're working on? I can bump the version on pypi if you want. |
Contributor
Author
|
No need to bump the pypi version for this small change. It can wait for a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
sessionargument toWindow.move_window, and supplied a default empty string argument to thedestinationarg.This allows you to pass a session ID to
Window.move_window, which will cause the window to change sessions.I've also updated the tests to include explicit coverage for
Window.move_window(with and without session moving) andServer.new_session.