Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc950b0fa1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| (let ((ai-code-session-link--project-files-cache | ||
| (ai-code-session-link--buffer-project-files-cache)) |
There was a problem hiding this comment.
Reusing ai-code-session-link--buffer-project-files-cache across all relinkify passes makes basename resolution stale when the project file set changes during a session. After this commit, newly created files (or deleted/moved files) are not reflected because ai-code-session-link--project-files keeps returning the cached list, so basename-only links like Foo.java:12 can fail to link (or link to removed files) until the buffer is recreated.
Useful? React with 👍 / 👎.
| (and ai-code-session-link-enabled | ||
| (buffer-live-p buffer) | ||
| (ai-code-session-link--recent-output-may-contain-links-p output))) |
There was a problem hiding this comment.
The new gate only linkifies when the current output chunk matches ai-code-session-link--recent-output-candidate-regexp, but process filters can split tokens arbitrarily across chunks. If a file/URL token spans chunk boundaries and no individual chunk matches, relinkification is skipped entirely, so valid links in the rendered tail are never made clickable.
Useful? React with 👍 / 👎.
1 participant
No description provided.