Release v0.10.4#130
Conversation
- Bump version to 0.10.4 - Refresh docs/current-state.md for v0.10.4 - Update summary golden files for version bump Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project version from 0.10.3 to 0.10.4 across the changelog, build information, documentation, and test data. Review feedback identifies a potential duplication of the version definition in the daemon package, which contradicts the intended single source of truth in the buildinfo package. Additionally, a minor decrease in total test coverage was noted in the documentation updates and should be reviewed to ensure no critical paths are left untested.
|
|
||
| // Version is the single source of truth for the AXIS release string. | ||
| const Version = "0.10.3" | ||
| const Version = "0.10.4" |
There was a problem hiding this comment.
The comment on line 3 states that Version is the "single source of truth", yet internal/daemon/handlers.go (line 83) uses an unqualified Version identifier without importing the buildinfo package. This suggests a duplicate version definition exists within the daemon package, which can lead to inconsistent version reporting (e.g., the API reporting an old version while the CLI reports the new one). Please ensure all packages use buildinfo.Version.
| - `coverage gate passed: internal/mcp 88.7% >= 35.0%` | ||
| - `coverage gate passed: internal/ui 94.0% >= 80.0%` | ||
| - `coverage gate passed: total 73.8% >= 45.0%` | ||
| - `coverage gate passed: total 73.0% >= 45.0%` |
There was a problem hiding this comment.
The total test coverage has decreased from 73.8% to 73.0%. While this still satisfies the 45% coverage gate, a regression in coverage during a release cycle should be reviewed to ensure no critical paths are left untested.
1 participant
Version bump and documentation refresh for v0.10.4.\n\n- Bump version to 0.10.4\n- Refresh docs/current-state.md\n- Update summary golden files for version bump\n\nAll quality gates pass.