Made git tag identification more conservative#219
Merged
Conversation
tobami
approved these changes
Apr 19, 2017
Owner
tobami
left a comment
tobami
left a comment
There was a problem hiding this comment.
Indeed describe is not the right git command here, good one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the behavior of
gitprojects to only identify a commit as being tagged when a tag points at the specific commit.Currently, virtually every commit will be shown as tagged. This makes it difficult to pick out specific commits (e.g., a previous release) as points of comparison in the comparisons view. For what it's worth, the
githubrepos already perform the same way.