Fix DisposedError during slow batch embedding#41
Merged
Conversation
Call touchActivity() after each successful embedding to prevent the inactivity timeout from disposing the context mid-batch. On slow systems (CPU-only), batch embedding can take much longer than the 2-minute inactivity timeout, causing the context to be disposed while embeddings are still in progress. Fixes tobi#40
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical issue where the qmd embed command fails with DisposedError on slow systems (CPU-only) during batch embedding operations. The root cause is that the 2-minute inactivity timeout disposes the context while embeddings are still in progress. The fix adds a touchActivity() call after each successful embedding to reset the inactivity timer.
Changes:
- Added
touchActivity()call inembedBatch()method after each successful embedding to prevent premature context disposal during long-running batch operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anrahya
pushed a commit
to Anrahya/qmd
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call touchActivity() after each successful embedding to prevent the inactivity timeout from disposing the context mid-batch.
On slow systems (CPU-only), batch embedding can take much longer than the 2-minute inactivity timeout, causing the context to be disposed while embeddings are still in progress.
Fixes #40