fix(db): declare transaction() on local Database interface#579
Open
lukeboyett wants to merge 1 commit intotobi:mainfrom
Open
fix(db): declare transaction() on local Database interface#579lukeboyett wants to merge 1 commit intotobi:mainfrom
lukeboyett wants to merge 1 commit intotobi:mainfrom
Conversation
The narrow cross-runtime Database interface in src/db.ts defines the subset of better-sqlite3 / bun:sqlite methods used throughout QMD. Commit fee576b ("fix: migrate legacy lowercase paths on reindex") introduced a db.transaction(...) call in src/store.ts but did not extend the interface, breaking `tsc -p tsconfig.build.json`: src/store.ts(2142,22): error TS2339: Property 'transaction' does not exist on type 'Database'. Both underlying engines expose transaction(fn), so this just makes the type reflect reality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cross-runtime
Databaseinterface insrc/db.tsdeclares the subset ofbetter-sqlite3/bun:sqlitemethods QMD uses. Commit fee576b ("fix: migratelegacy lowercase paths on reindex") introduced a
db.transaction(...)call insrc/store.ts:2142but didn't extend the interface, sotsc -p tsconfig.build.jsonfails on main:
Both underlying engines expose
transaction(fn), so this one-line addition justmakes the type reflect reality.
Change
export interface Database { exec(sql: string): void; prepare(sql: string): Statement; loadExtension(path: string): void; + transaction<T extends (...args: any[]) => any>(fn: T): T; close(): void; }Validation
npm run buildis green with this change, red without it (reproduced on currentmainatcfd640e).TS2339onmainand flagged it as a build-blocker.Test plan
npm run buildpassesnpm test— no new failures vs.mainbaseline