fix(docs): mcp-setup.md params out of sync with mcp.ts schemas#95
Closed
ramonclaudio wants to merge 1 commit intotobi:mainfrom
Closed
fix(docs): mcp-setup.md params out of sync with mcp.ts schemas#95ramonclaudio wants to merge 1 commit intotobi:mainfrom
ramonclaudio wants to merge 1 commit intotobi:mainfrom
Conversation
ramonclaudio
force-pushed
the
fix/stale-docs
branch
from
b6773d8 to
379ef29
Compare
ramonclaudio
force-pushed
the
fix/stale-docs
branch
from
379ef29 to
f8502b1
Compare
ramonclaudio
changed the title
ramonclaudio
force-pushed
the
fix/stale-docs
branch
from
f8502b1 to
46ca80f
Compare
ramonclaudio
changed the title
ramonclaudio
force-pushed
the
fix/stale-docs
branch
from
46ca80f to
c8b318b
Compare
ramonclaudio
changed the title
ramonclaudio
force-pushed
the
fix/stale-docs
branch
from
c8b318b to
4589df1
Compare
ramonclaudio
changed the title
ramonclaudio
force-pushed
the
fix/stale-docs
branch
2 times, most recently
from
54003b6 to
a58f55b
Compare
MCP-SETUP.md had stale parameter documentation for several tools: - qmd_get: param was `path` (actual: `file`), listed nonexistent `full` param, missing `fromLine` and `maxLines` - qmd_multi_get: missing `maxLines` and `lineNumbers` params - qmd_search/vsearch/query: limit default documented as 5 (actual: 10) Also fixes showHelp() model name — still showed the old Qwen3-0.6B-Q8_0 after the switch to the fine-tuned qmd-query-expansion-1.7B model.
ramonclaudio
force-pushed
the
fix/stale-docs
branch
from
a58f55b to
7e362d8
Compare
ramonclaudio
changed the title
Author
|
MCP docs still stale but closing out. The corrections are documented in the PR if anyone needs them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.1.0 rewrote the MCP layer but
mcp-setup.mdwasn't updated. Wrong tool name, wrong param names, ghost params that don't exist.What was wrong
Verified line-by-line against
inputSchemainsrc/mcp.ts:structured_searchquerymcp.ts:243queryexample"collection": "optional""collections": ["optional-collection-name"]mcp.ts:310,z.array(z.string())getparampathfilemcp.ts:364getparamfull(doesn't exist)getparamsfromLine,maxLinesmcp.ts:365-366multi_getparamsmaxLines,lineNumbersmcp.ts:430,432The
collection->collectionsone is the worst. Sending{ "collection": "docs" }gets silently ignored by the schema validator. Filter never applies.Changes
skills/qmd/references/mcp-setup.mdonly (+8/-5).Test plan
querymatchesserver.registerTool("query", ...)atmcp.ts:243collectionsisz.array(z.string()).optional()atmcp.ts:310getparams matchmcp.ts:364-367(file,fromLine,maxLines,lineNumbers)multi_getparams matchmcp.ts:429-432(pattern,maxLines,maxBytes,lineNumbers)statushas no params (mcp.ts:501: inputSchema: {})