Fix bin/try to work with gem installation #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installed via gem, require_relative doesn't trigger the if __FILE__ == $0 guard in try.rb because $0 points to bin/try, not try.rb. Use load with $0 set to try.rb path so the guard evaluates to true. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
@tobi gem install (recommended way as per the docs) does not work correctly, please take a look at the quick fix |
3 tasks
|
This would fix #92! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
bin/tryto properly set$0when loadingtry.rb, ensuring gem installation works correctlyProblem
When installed as a gem,
try.rbuses$0to determine its own script path (line 996:script_path = File.expand_path($0)). The previousrequire_relative '../try'approach left$0pointing tobin/tryinstead of
try.rb, breaking self-referential path logic.Solution
Replace
require_relativewith explicit$0assignment andload:This ensures try.rb sees the correct path in $0 whether run locally or via gem installation.