Locale and translations for "System Settings" App#183
Merged
tobychui merged 19 commits intotobychui:2.022from Mar 20, 2025
Merged
Locale and translations for "System Settings" App#183tobychui merged 19 commits intotobychui:2.022from
tobychui merged 19 commits intotobychui:2.022from
Conversation
Owner
|
Generally looks ok, will merge into the dev branch and test it over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the translation work for System Settings across all supported languages (Simplified Chinese, Traditional Chinese (HK and TW), Japanese and Korean). HTML layout has also been optimized to match the locale needs.
404 page has been localized as well and I also did some minor tweaks for existing translations.
However, I've noticed a new issue: Using
applocale.jscause too much performance decrease, and if nested pages useapplocale.jsit will cause too many requests on it, and some browsers might fail to load the JS prooperly, and locales will not show as a result.Additionally, I propose a potential migration of locale rendering from the JS frontend to the Go backend. Rendering HTML and serving it directly will definately solve the issue, but it might comsume a little bit more on the server side. Further performance validation is required before finalizing this change.
Details
Next Steps