feat: add configuration to exclude author from mentions #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tobyhs
approved these changes
Oct 19, 2024
Owner
tobyhs
left a comment
tobyhs
left a comment
There was a problem hiding this comment.
lgtm, although I'm also fine with not having an excludeAuthor option and just unconditionally excluding the author from mentions. Let me know if this is preferable and you want to update this PR for that approach, or if you want to stick with the current approach.
I'll update the build-test GitHub workflow to run npm run format-check later to catch format/prettier issues in the future.
Contributor
Author
|
Thinking about it more, yep, I think it makes sense for this to be the behavior. I'll update the PR early next week. |
tobyhs
added a commit
to tobyhs/codemention-test
that referenced
this pull request
Oct 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Some members of the expo/expo repo have expressed interest in excluding the author of the PR from the mentions. This PR adds the ability to conditionally configure this behavior.
How
Add
excludeAuthoras a top-level configuration option to the configuration yaml. Filter the matched rules if set.Note that this PR also runs the
formatscript so some incorrectly-formatted code from previous PRs is corrected.Test Plan
Run test.
Tried to test in expo#5 but I believe 6bf157a makes fork workflows run with the
tobyhs/codemention@main. I guess I could override for the fork, but I think the test provides enough confidence for this.