feat(duckdb): Add transpilation support for SPACE function#6867
Merged
Conversation
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 6965 total, 6346 passed (pass rate: 91.1%), sqlglot version: sqlglot:RD-1147757-space: 6965 total, 6348 passed (pass rate: 91.1%), sqlglot version: Difference: No change |
georgesittas
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transpilation of SPACE() to REPEAT() fails in DuckDB when the input argument is a FLOAT or DECIMAL type because DuckDB's REPEAT() function strictly requires the second argument (repeat count) to be of type BIGINT. SQLGlot currently transpiles SPACE(n) to REPEAT(' ', n) without adding the necessary type cast, causing runtime errors.
Fix: Added a custom space_sql method in the DuckDB dialect to wrap the count argument with CAST to BIGINT.
After Fix: