fix(snowflake): transpile REDUCE to DuckDB LIST_REDUCE#7505
Merged
georgesittas merged 5 commits intomainfrom Apr 16, 2026
Merged
fix(snowflake): transpile REDUCE to DuckDB LIST_REDUCE#7505georgesittas merged 5 commits intomainfrom
georgesittas merged 5 commits intomainfrom
Conversation
georgesittas
approved these changes
Apr 16, 2026
| def reduce_sql(self, expression: exp.Reduce) -> str: | ||
| # DuckDB's LIST_REDUCE doesn't support a finish function, so preserve REDUCE as-is | ||
| if expression.args.get("finish"): | ||
| return self.function_fallback_sql(expression) |
Collaborator
There was a problem hiding this comment.
Just decorate the function with @unsupported("finish") instead of falling back here.
Collaborator
|
@fivetran-ashashankar when conflicts are resolved feel free to merge. |
fivetran-ashashankar
force-pushed
the
RD-1147682-transpile-REDUCE
branch
from
aa668ae to
e6c0711
Compare
…arameter Replace manual fallback check with @unsupported_args decorator as suggested in PR review.
georgesittas
force-pushed
the
RD-1147682-transpile-REDUCE
branch
from
e6c0711 to
fa7b226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for transpiling Snowflake's REDUCE function to DuckDB's LIST_REDUCE.