fix(redshift): support APPROXIMATE PERCENTILE_DISC round-trip#7585
Merged
georgesittas merged 1 commit intomainfrom Apr 30, 2026
Merged
fix(redshift): support APPROXIMATE PERCENTILE_DISC round-trip#7585georgesittas merged 1 commit intomainfrom
georgesittas merged 1 commit intomainfrom
Conversation
georgesittas
approved these changes
Apr 30, 2026
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 113236 total, 112046 passed (pass rate: 98.9%), sqlglot version: sqlglot:fix/redshift-approximate-percentile: 101037 total, 101037 passed (pass rate: 100.0%), sqlglot version: Transitions: Dialect pair changes: 0 previous results not found, 3 current results not found ✅ 38 test(s) passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APPROXIMATE PERCENTILE_DISC(p) WITHIN GROUP (ORDER BY x)is valid Redshift syntax that was causing aParseErroron round-trip._parse_approximate_countonly handledAPPROXIMATE COUNT(DISTINCT ...)— when it saw aPercentileDiscit retreated, leavingAPPROXIMATEstranded in the projection list.To fix, another branch was added to
_parse_approximate_countand generator was updated to outputexp.ApproxQuantilecorrectly.