fix(exasol): case-insensitive alias matching for LOCAL. prefix #7631
Merged
Conversation
georgesittas
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_add_local_prefix_for_aliasesdid case-sensitive string matching when rewriting alias references toLOCAL.<alias>inWHERE/GROUP BY/HAVING. Exasol folds unquoted identifiers to uppercase, so an aliasidFieldand a referenceidfieldare the same identifier but the lookup missed, producing invalid SQL:Fix: use
dialect.normalize_identifier()to compute the comparison key. Theexp.Selectpreprocessing moves into aselect_sqloverride soself.dialectis available.We went with this approach, because now Exasol supports setting a different normalization strategy, so the function would work consistently when using an extended Exasol dialect using a different normalization strategy.
Tests added to
test_local_prefix_for_alias. Verified against a live Exasol instance.