Skip to content

Force a User-Agent string that is NOT the default Python-urlib.#138

Merged
bradjc merged 1 commit into
tock:masterfrom
radnvlad:feature/fix_useragent
Mar 30, 2026
Merged

Force a User-Agent string that is NOT the default Python-urlib.#138
bradjc merged 1 commit into
tock:masterfrom
radnvlad:feature/fix_useragent

Conversation

@radnvlad
Copy link
Copy Markdown
Contributor

The default user-agent led to the connection being dropped.

This is especially annoying since the rampup documentation is telling you to download the tab from an URL and then that doesn't work.

Not sure if there are any other implications here, but at least the demo blink now works to be downloaded. I think this is annoying enough to warrant a release, actually, but your call.

Credit for the fix goes to Claude, but I was the one wondering what the heck was going on and why the doc instructions were failing.

Copy link
Copy Markdown
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing a custom user agent is a good idea.

Can you check whether there are any other uses of urllib in the code that we should adjust?

@radnvlad
Copy link
Copy Markdown
Contributor Author

Providing a custom user agent is a good idea.

Can you check whether there are any other uses of urllib in the code that we should adjust?

Just checked. The other use is validating if the string is an URL and that won't access any site. So this should be it.

@lschuermann lschuermann requested a review from bradjc February 26, 2026 17:07
@radnvlad
Copy link
Copy Markdown
Contributor Author

radnvlad commented Mar 9, 2026

@bradjc - what do you think of this PR?

@bradjc bradjc merged commit bf61eb3 into tock:master Mar 30, 2026
2 checks passed
@radnvlad radnvlad deleted the feature/fix_useragent branch March 30, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants