Color 이슈 및 iOS 26 대응 #199
Merged
Color 이슈 및 iOS 26 대응 #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Walkthrough의존성 잠금 파일(Package.resolved)의 여러 리비전/버전 핀을 갱신했다. SwiftUI 컴포넌트 Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as 사용자
participant MV as MainView
participant Menu as 날짜 선택 Menu
participant Policy as DatePolicy / UserDefaults
participant Log as Analytics
User->>MV: 상단 날짜 메뉴 탭
MV->>Menu: 날짜 목록 표시(어제/오늘/내일)
Menu->>Policy: 각 항목 날짜 계산(주말/저녁 스킵 규칙 포함)
Policy-->>Menu: 계산된 날짜들
User->>Menu: 항목 선택
Menu->>Log: 선택 텐스 이벤트 로깅
Menu->>MV: 선택된 날짜 전달 (dateSelected 액션)
MV->>MV: 표시 날짜 업데이트 및 메뉴 닫기
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
✅ Successful finished SwiftLint |
Contributor
✅ PR의 Assign 자동 지정을 성공했어요! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
Package.resolved(6 hunks)Projects/Feature/MainFeature/Sources/Components/DateTensePickerView.swift(0 hunks)Projects/Feature/MainFeature/Sources/MainView.swift(3 hunks)Projects/UserInterface/DesignSystem/Sources/TopTabbar/TopTabbar.swift(1 hunks)
💤 Files with no reviewable changes (1)
- Projects/Feature/MainFeature/Sources/Components/DateTensePickerView.swift
🧰 Additional context used
🧬 Code graph analysis (1)
Projects/Feature/MainFeature/Sources/MainView.swift (2)
Projects/Feature/MainFeature/Sources/DatePolicy.swift (3)
previousDay(55-67)nextDay(69-81)displayText(12-33)Projects/Shared/TWLog/Sources/TWLog.swift (1)
event(63-68)
🪛 GitHub Check: swiftlint
Projects/Feature/MainFeature/Sources/MainView.swift
[warning] 156-156:
Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
[warning] 155-155:
Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: 🧪 Test
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Projects/Feature/MainFeature/Sources/MainCore.swift(0 hunks)Projects/Feature/MainFeature/Sources/MainView.swift(2 hunks)
💤 Files with no reviewable changes (1)
- Projects/Feature/MainFeature/Sources/MainCore.swift
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-28T05:44:11.639Z
Learnt from: baekteun
PR: todaywhat/TodayWhat-iOS#199
File: Projects/Feature/MainFeature/Sources/MainView.swift:115-170
Timestamp: 2025-09-28T05:44:11.639Z
Learning: SwiftUI Menu의 content closure 안에서 let 선언이 정상적으로 작동합니다. Menu content builder가 지역 변수 선언을 지원하므로 컴파일 에러가 발생하지 않습니다.
Applied to files:
Projects/Feature/MainFeature/Sources/MainView.swift
🧬 Code graph analysis (1)
Projects/Feature/MainFeature/Sources/MainView.swift (2)
Projects/Feature/MainFeature/Sources/DatePolicy.swift (3)
previousDay(55-67)nextDay(69-81)displayText(12-33)Projects/Shared/TWLog/Sources/TWLog.swift (1)
event(63-68)
🪛 GitHub Check: swiftlint
Projects/Feature/MainFeature/Sources/MainView.swift
[warning] 155-155:
Vertical Whitespace Violation: Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
[warning] 154-154:
Trailing Whitespace Violation: Lines should not have trailing whitespace (trailing_whitespace)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
Color 이슈 및 iOS 26 대응
Summary by CodeRabbit