Skip to content

Conversation

@graydawnc
Copy link
Collaborator

@graydawnc graydawnc commented May 30, 2025

Closes: BS-3370

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 30, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graydawnc graydawnc marked this pull request as ready for review May 30, 2025 09:35
@graydawnc graydawnc requested a review from a team as a code owner May 30, 2025 09:35
@graphite-app graphite-app bot requested review from a team May 30, 2025 09:35
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 48 lines in your changes missing coverage. Please review.

Project coverage is 55.65%. Comparing base (2795e99) to head (d046835).

Files with missing lines Patch % Lines
.../blocks/bookmark/src/bookmark-citation-renderer.ts 33.33% 10 Missing ⚠️
...ed-doc-block/embed-linked-doc-citation-renderer.ts 9.09% 10 Missing ⚠️
...cks/attachment/src/attachment-citation-renderer.ts 10.00% 9 Missing ⚠️
...e/affine/blocks/attachment/src/attachment-block.ts 0.00% 6 Missing ⚠️
...c/embed-linked-doc-block/embed-linked-doc-block.ts 0.00% 5 Missing ⚠️
...suite/affine/blocks/bookmark/src/bookmark-block.ts 50.00% 1 Missing and 2 partials ⚠️
...blocks/attachment/src/attachment-edgeless-block.ts 0.00% 1 Missing ⚠️
...inked-doc-block/embed-edgeless-linked-doc-block.ts 0.00% 1 Missing ⚠️
...c/embed-synced-doc-block/embed-synced-doc-block.ts 0.00% 1 Missing ⚠️
...ine/blocks/embed/src/common/embed-block-element.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                             Coverage Diff                             @@
##           05-30-feat_editor_track_citation_events   #12665      +/-   ##
===========================================================================
- Coverage                                    55.65%   55.65%   -0.01%     
===========================================================================
  Files                                         2652     2656       +4     
  Lines                                       125038   125078      +40     
  Branches                                     19777    19783       +6     
===========================================================================
+ Hits                                         69592    69609      +17     
+ Misses                                       53702    53169     -533     
- Partials                                      1744     2300     +556     
Flag Coverage Δ
server-test 79.01% <ø> (ø)
unittest 31.66% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graydawnc graydawnc force-pushed the 05-30-feat_editor_track_citation_events branch from a5c9ca1 to 2795e99 Compare May 30, 2025 09:43
@graydawnc graydawnc force-pushed the 05-30-refactor_editor_refactor_citation_renderer_as_an_extension branch from fe4d311 to d046835 Compare May 30, 2025 09:43
@graydawnc graydawnc marked this pull request as draft May 30, 2025 09:59
@graydawnc graydawnc closed this Jun 5, 2025
@lawvs lawvs deleted the 05-30-refactor_editor_refactor_citation_renderer_as_an_extension branch December 4, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants