[TCL-2751] Slinky v1.0: fix chart rendering, reconfigure deadlock, login auth, and SLURM_CONF_SERVER#18
Merged
jhu-svg merged 4 commits intoslurm-1.0-together-changesfrom Mar 11, 2026
Conversation
Made-with: Cursor
Made-with: Cursor
1. reconfigure sidecar: initialize lastHash to current config hash on startup so no spurious scontrol-reconfigure fires while slurmctld is still initializing (avoids a deadlock in slurm 25.11.2). 2. login deployment: mount slurm-auth-slurm and slurm-auth-jwths256 secrets alongside the slurm-config configmap using a projected volume with mode 0600. sackd needs the slurm.key for bootstrap auth. 3. login SLURM_CONF_SERVER env: point to the controller service (slurm-controller) instead of the non-existent "slurm" service. Made-with: Cursor
Made-with: Cursor
jhu-svg
changed the title
jhu-svg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 6 issues blocking Slinky v1.0 Slurm clusters from provisioning correctly.
Chart rendering fixes
slurm.dnsConfighelper (TCL-4404) — login template called undefined helperauthcredinitContainer (TCL-4404) — referenced templates from upstream that don't exist in our forkSACKD_OPTIONSenv var (TCL-4408) — login entrypoint needs this for sackd to connect to controllerReconfigure sidecar deadlock fix
lastHashinreconfigure.sh(TCL-4401) — the sidecar started withlastHash="", always triggeringscontrol reconfigureon startup, which deadlocks slurmctld 25.11.2. Now captures initial hash before polling.Login auth fixes
slurm-auth-slurmandslurm-auth-jwths256secrets needed by sackd for bootstrap auth. Uses projected volume withdefaultMode: 0600.SLURM_CONF_SERVERenv var (TCL-4403) — pointed toslurm.slurm.svc(doesn't exist), changed toslurm-controller.slurm.svc.Linear
Test
helm templatepassest-f7eeaf3a)"