feat(api): Port finetuning create code from together-python #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-48363 Make Python finetuning create custom coded and not Stainless controlled
A decision with the fine tuning team is that we should preserve the previous logic for the fine-tuning create logic for Python. The action steps here are:
|
blainekasten
force-pushed
the
blaine/eng-48363-make-python-finetuning-create-custom-coded-and-not-stainless
branch
4 times, most recently
from
0f4d72b to
284c534
Compare
blainekasten
force-pushed
the
blaine/eng-48363-make-python-finetuning-create-custom-coded-and-not-stainless
branch
2 times, most recently
from
33bbf49 to
ac0b129
Compare
blainekasten
force-pushed
the
blaine/eng-48363-make-python-finetuning-create-custom-coded-and-not-stainless
branch
from
ac0b129 to
48eb2a3
Compare
artek0chumak
approved these changes
Nov 21, 2025
| # object type | ||
| object: Literal["fine-tune-event"] | ||
| # created at datetime stamp | ||
| created_at: Union[str, None] = None |
There was a problem hiding this comment.
Not necessary to change it, I can do it later in another PR.
- Should we switch str | None here?
- Do we want to support 3.9 or we can switchto >= 3.10?
Contributor
Author
There was a problem hiding this comment.
This may be a question for us to discuss with Stainless. All of their generated types use this Syntax so there may be a reason.
Do you have an opinion on supporting 3.9 or not?
newokaerinasai
approved these changes
Nov 21, 2025
Merged
blainekasten
added a commit
that referenced
this pull request
Nov 21, 2025
* chore(api): Remove auto-generated fine_tuning.create method from Python SDK * feat(api): Change image creation signature to `images.generate` BREAKING CHANGE: For the TS SDK the `images.create` is now `images.generate` * feat(api): Change fine tuning download method to `.create` BREAKING CHANGE: Change Fine Tuning method name from `download()` to `content()` to align with other namespaces * feat(api): api update * feat(api): Change rerank method signature BREAKING CHANGE: Update method signature for reranking to `rerank.create()` * feat(api): Port finetuning create code from together-python (#176) * chore: Fix examples * release: 2.0.0-alpha.1 --------- Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com> Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.