Merged
Conversation
Contributor
nikita-smetanin
commented
Mar 17, 2026
nikita-smetanin
commented
- Fix checkpoint step propagation
- Fix minor issues with parameters and docstrings
|
|
||
| for arg in default_values: | ||
| arg_source = ctx.get_parameter_source("arg") # type: ignore[attr-defined] | ||
| arg_source = ctx.get_parameter_source(arg) # type: ignore[attr-defined] |
Contributor
There was a problem hiding this comment.
lol that should have been more obvious in the past
| client: Together = ctx.obj | ||
|
|
||
| checkpoints = client.fine_tuning.list_checkpoints(fine_tune_id) | ||
| checkpoints.data = checkpoints.data or [] |
Contributor
There was a problem hiding this comment.
could we fix this server side to make sure data is always returned as an array? I'm fine with having this in here temporarily. But the api should be stable in it's response shape
sbassam
reviewed
Mar 17, 2026
|
|
||
| rprint(JSON.from_data(response.model_dump(exclude_none=True), default=datetime_serializer)) | ||
| progress_text = generate_progress_bar(response, datetime.now().astimezone(), use_rich=True) | ||
| progress_text = generate_progress_bar(response, datetime.now(timezone.utc), use_rich=True) |
Contributor
Author
There was a problem hiding this comment.
There was some complaint from claude about issues on systems with no timezone set.
sbassam
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.