Add progress bar for Fine-tuning jobs #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artek0chumak
changed the title
| if use_rich: | ||
| return progress | ||
|
|
||
| return re.sub(r"\[/?[^\]]+\]", "", progress) |
There was a problem hiding this comment.
Is it possible to produce desired output format directly to avoid regexs?
| ) | ||
| percentage = ratio_filled * 100 | ||
| filled = math.ceil(ratio_filled * _PROGRESS_BAR_WIDTH) | ||
| bar = "█" * filled + "░" * (_PROGRESS_BAR_WIDTH - filled) |
There was a problem hiding this comment.
Might there be off-the-shelf libs to use for this?
|
|
||
| elapsed_time = (current_time - update_at).total_seconds() | ||
| ratio_filled = min( | ||
| elapsed_time / finetune_job.progress.seconds_remaining, 1.0 |
There was a problem hiding this comment.
Don't we get this progress from API?
Contributor
Author
There was a problem hiding this comment.
Discussed offline, we don't
| response.events = None | ||
|
|
||
| click.echo(json.dumps(response.model_dump(exclude_none=True), indent=4)) | ||
| rprint(JSON.from_data(response.model_dump(exclude_none=True))) |
Contributor
There was a problem hiding this comment.
So we switch to rprint in spirit of depreciation?
newokaerinasai
approved these changes
Dec 15, 2025
nikita-smetanin
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # MOSH-746
Describe your changes
This PR adds progress bar for the FT jobs.