Skip to content

Comments

Migrate to new IO library and add GitHub actions.#8

Merged
floitsch merged 2 commits intomainfrom
floitsch/io
Apr 5, 2024
Merged

Migrate to new IO library and add GitHub actions.#8
floitsch merged 2 commits intomainfrom
floitsch/io

Conversation

@floitsch
Copy link
Member

@floitsch floitsch commented Apr 4, 2024

No description provided.

@floitsch floitsch requested a review from kasperl April 4, 2024 13:51
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/tar.toit Outdated

/**
Closes the tar stream, and invokes `close_write` on the stored writer if $close_writer is true.
Closes the tar stream, and invokes 'close' if $close_writer is true.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invokes close on what? I hope it is not infinite recursion :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@floitsch floitsch merged commit c5d75bd into main Apr 5, 2024
@floitsch floitsch deleted the floitsch/io branch April 5, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants