Return the created devices as json.#1076
Merged
Merged
Conversation
kasperl
approved these changes
Jun 8, 2024
| --group=group | ||
| --output-directory=output-directory | ||
| written-count++ | ||
| written-ids["$id"] = path |
Contributor
There was a problem hiding this comment.
So you get a map from id to path out. Cute.
| printer.emit-structured | ||
| --json=: written-ids | ||
| --stdout=: | printer/Printer | | ||
| if count == written-ids.size or written-ids.size > 0: |
Contributor
There was a problem hiding this comment.
If find it hard to reason about the condition here. Maybe add a comment to explain what is going on?
If we've written the last one (count == written-ids.size) then it makes sense to report the number of files created. Why does it make sense to always repoted this if written-ids.size > 0?
Member
Author
There was a problem hiding this comment.
improved the code and added a comment.
done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.