Skip to content

Make the authentication more flexible for brokers.#1090

Merged
floitsch merged 3 commits into
mainfrom
floitsch/login.10.auth-login-server
Jun 17, 2024
Merged

Make the authentication more flexible for brokers.#1090
floitsch merged 3 commits into
mainfrom
floitsch/login.10.auth-login-server

Conversation

@floitsch
Copy link
Copy Markdown
Member

No description provided.

@floitsch floitsch requested a review from kasperl June 14, 2024 16:43
Copy link
Copy Markdown
Contributor

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread src/cli/cmds/auth.toit Outdated
--help="""
Updates the email or password for an account.

If '--broker' is provided, authenticates with the default broker.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to change 'authenticates' in this help section with something else?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.
done.

Comment thread src/cli/server-config.toit Outdated
if not servers or not servers.contains name:
if name == DEFAULT-ARTEMIS-SERVER-CONFIG.name:
return DEFAULT-ARTEMIS-SERVER-CONFIG
ui.abort "No server entry for '$name' in the config"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ui.abort "No server entry for '$name' in the config"
ui.abort "No server entry for '$name' in the config."

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@floitsch floitsch enabled auto-merge (squash) June 17, 2024 08:37
@floitsch floitsch merged commit 096ceaf into main Jun 17, 2024
@floitsch floitsch deleted the floitsch/login.10.auth-login-server branch June 17, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants