Skip to content

Don't create separate analytic event types for different pages#212

Merged
kasperl merged 1 commit intomasterfrom
fix-analytics
Sep 18, 2022
Merged

Don't create separate analytic event types for different pages#212
kasperl merged 1 commit intomasterfrom
fix-analytics

Conversation

@kasperl
Copy link
Contributor

@kasperl kasperl commented Sep 18, 2022

The call to analytics.page was incorrect. The first (optional) argument is the event category. The path is automatically included.

@kasperl kasperl requested a review from floitsch September 18, 2022 08:44
Copy link
Member

@floitsch floitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kasperl kasperl merged commit b28fdd0 into master Sep 18, 2022
@kasperl kasperl deleted the fix-analytics branch September 18, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants