Fix frontend transaction details success message#11
Merged
kchiranjewee63 merged 2 commits intomainfrom May 1, 2024
Merged
Conversation
c0d2b20 to
4706f92
Compare
tulshi
reviewed
Apr 26, 2024
tulshi
previously approved these changes
Apr 26, 2024
Member
|
Instead of "Total Revenue", you should say "Total Proceeds"
…On Thu, Apr 25, 2024 at 6:35 PM Chiranjeewee Koirala < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
example-application/frontend/src/app/components/order/transaction-details/transaction-details.component.html
<#11 (comment)>:
> @@ -10,7 +10,12 @@ <h2>Transaction Successful!</h2>
<p><strong>Operation:</strong> {{ transactionDetails.operation }}</p>
<p><strong>Stock:</strong> {{ transactionDetails.stockName }} ({{ transactionDetails.stockSymbol }})</p>
<p><strong>Quantity:</strong> {{ transactionDetails.quantity }}</p>
- <p><strong>Total Cost:</strong> {{ transactionDetails.totalValue | currency }}</p>
+ <ng-container *ngIf="transactionDetails.operation === 'Buy'; else sellBlock">
+ <p><strong>Total Cost:</strong> {{ transactionDetails.totalValue | currency }}</p>
+ </ng-container>
+ <ng-template #sellBlock>
+ <p><strong>Total Revenue:</strong> {{ transactionDetails.totalValue | currency }}</p>
Currently, if a user buys shares, we show "Total Cost." And if a user
sells shares, we show "Total Revenue."
I don't know if this is right. Let me know what should we put. I will
change it.
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB55UG467CNEPEWK47G4L73Y7GVPPAVCNFSM6AAAAABGXQPOWWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRTHEYTCNRUG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
tulshi
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.