implemented disable distribution gov proposal in pse module#41
implemented disable distribution gov proposal in pse module#41
Conversation
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @miladz68, and @TxCorpi0x)
a discussion (no related file):
verifying if gov integration is correct
x/pse/keeper/keeper.go line 38 at r1 (raw file):
AccountScoreSnapshot collections.Map[sdk.AccAddress, sdkmath.Int] AllocationSchedule collections.Map[uint64, types.ScheduledDistribution] // Map: timestamp -> ScheduledDistribution DisableDistributionsColl collections.Item[bool]
by Coll do you mean collections ?
Maybe you want to name
- store: DistributionsDisabled / DistributionsDisabled{Some_Suffix}
- func/actions: DisableDistributions
or these are too similar and might be confusing ?
I'm also ok to keep current version
Code quote:
DisableDistributionsColl
miladz68
left a comment
There was a problem hiding this comment.
Reviewable status: 8 of 20 files reviewed, 2 unresolved discussions (waiting on @masihyeganeh, @TxCorpi0x, and @ysv)
a discussion (no related file):
Previously, ysv (Yaroslav Savchuk) wrote…
verifying if gov integration is correct
what do we need to do here ?
x/pse/keeper/keeper.go line 38 at r1 (raw file):
Previously, ysv (Yaroslav Savchuk) wrote…
by Coll do you mean collections ?
Maybe you want to name
- store: DistributionsDisabled / DistributionsDisabled{Some_Suffix}
- func/actions: DisableDistributions
or these are too similar and might be confusing ?
I'm also ok to keep current version
Done.
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 12 of 12 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @TxCorpi0x)
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x reviewed 8 of 19 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
ysv
left a comment
There was a problem hiding this comment.
@ysv reviewed 6 of 6 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
TxCorpi0x
left a comment
There was a problem hiding this comment.
@TxCorpi0x reviewed 6 of 6 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh)
Description
Reviewers checklist:
Authors checklist
This change is