windows: use the default IOCP concurrency value.#1161
Merged
carllerche merged 2 commits intov0.6.xfrom Nov 22, 2019
Merged
Conversation
IOCP is initialized with the max number of threads that can be "associated" with the IOCP handle. A thread becomes associated with IOCP when it is woken after selecting. It remains associated with IOCP until the thread sleeps for any reason (blocking I/O, yield, page fault, sleep, ...). Currently, the value is set to 1. However, this was picked mostly because I had no idea what it meant to be "associated" with IOCP and 1 sounded good. It turns out that 0 is lets windows pick a default value (number of cores). This makes much more sense than 1. ref: https://docs.microsoft.com/en-us/windows/win32/fileio/i-o-completion-ports#threads-and-concurrency
piscisaureus
approved these changes
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IOCP is initialized with the max number of threads that can be
"associated" with the IOCP handle. A thread becomes associated with IOCP
when it is woken after selecting. It remains associated with IOCP until
the thread sleeps for any reason (blocking I/O, yield, page fault,
sleep, ...).
Currently, the value is set to 1. However, this was picked mostly
because I had no idea what it meant to be "associated" with IOCP and 1
sounded good. It turns out that 0 is lets windows pick a default value
(number of cores). This makes much more sense than 1.
ref: https://docs.microsoft.com/en-us/windows/win32/fileio/i-o-completion-ports#threads-and-concurrency