Skip to content

Allow error events to be handled in Handlers#138

Closed
CraZySacX wants to merge 2 commits intotokio-rs:masterfrom
CraZySacX:master
Closed

Allow error events to be handled in Handlers#138
CraZySacX wants to merge 2 commits intotokio-rs:masterfrom
CraZySacX:master

Conversation

@CraZySacX
Copy link

Currently error events just spit out the error message. This allows the handler to react to error events outside of readable and writable.

@carllerche
Copy link
Member

Ah yes... I completely forgot about this. I've been meaning to fix it :P

I'm wondering if it would be better to pass errors to the handler via readable and set the ReadHint -> error. The issue is that, I do not believe that every platform reliably detects errors without reading, so this may be a good case of just considering an error a "readable" event.

@CraZySacX
Copy link
Author

Yeah that sounds better. I'll close this pull request and submit another.

@CraZySacX CraZySacX closed this Mar 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants