windows: Remove the last HashMap in Selector#256
Closed
alexcrichton wants to merge 1 commit intotokio-rs:masterfrom
Closed
windows: Remove the last HashMap in Selector#256alexcrichton wants to merge 1 commit intotokio-rs:masterfrom
alexcrichton wants to merge 1 commit intotokio-rs:masterfrom
Conversation
This commit removes the last `HashMap` storage in the `Selector` on Windows, meaning that I/O scheduling and completion no longer has a `HashMap` lookup on either side. This was starting to show up in the profiles I was making and this basically erases that overhead.
alexcrichton
force-pushed
the
remove-handle-map
branch
from
404e864 to
372fdb5
Compare
Member
|
👍 |
Contributor
Author
|
Merged as 42904eb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the last
HashMapstorage in theSelectoron Windows,meaning that I/O scheduling and completion no longer has a
HashMaplookup oneither side. This was starting to show up in the profiles I was making and this
basically erases that overhead.