Merged
Conversation
Contributor
|
Nice! 💴 |
Based on #280 by luca-barbieri Currently run() results in the process waking up every second or every timer tick if set lower because a timeout is passed to the OS wait function. This changes the code so that run_once() still uses the timeout, but run() will instruct the OS to wait forever when there are no timers. The notify mechanism already uses a pipe for awakening the event loop, so there should be no need to use a timeout for that. This saves CPU time and battery, and is generally the correct behavior. Miscellaneous notes: * We also fix epoll because the maximum timeout supported by the Linux kernel is i32::MAX, not isize::MAX. * We fix next_tick_ms() being truncated from u64 to usize * It requires nix-rust/nix#192 to allow specifying no timeout to kevent() * The public API of Poll::poll is changed, but that can be avoided if desired. Closes #289
carllerche
force-pushed
the
reduce-unnecessary-wakups
branch
from
b6f6b23 to
7b73ce8
Compare
Contributor
There was a problem hiding this comment.
since std::time::Duration is stable, is there a reason not to use it?
Member
Author
There was a problem hiding this comment.
I will track this in the API ticket. To date Mio has used *_ms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #280 by luca-barbieri
Currently run() results in the process waking up every second or every timer
tick if set lower because a timeout is passed to the OS wait function.
This changes the code so that run_once() still uses the timeout, but
run() will instruct the OS to wait forever when there are no timers.
The notify mechanism already uses a pipe for awakening the event loop,
so there should be no need to use a timeout for that.
This saves CPU time and battery, and is generally the correct behavior.
Miscellaneous notes:
i32::MAX, not isize::MAX.
Closes #289