harden ref mut according to edition 2024#1248
Merged
caspermeijn merged 2 commits intotokio-rs:masterfrom Mar 28, 2025
Merged
Conversation
Signed-off-by: Xinye Tao <xinye.tao@metabit-trading.com>
caspermeijn
requested changes
Mar 12, 2025
Contributor
caspermeijn
left a comment
caspermeijn
left a comment
There was a problem hiding this comment.
This makes sense. After this PR is merged, I will add a test to actually verify our generated code is compatible with edition 2024. #1256
Please see the suggestion below
Comment on lines
-44
to
-48
| let MessageGraph { | ||
| ref mut index, | ||
| ref mut graph, | ||
| .. | ||
| } = *self; |
Contributor
There was a problem hiding this comment.
This change doesn't seem necessary for edition 2024, but it is an improvement nonetheless. The destructuring was probably needed in older compilers because of the usage of self inside and outside the closure.
Contributor
Author
There was a problem hiding this comment.
Yes, cleaned it up while searching for ref mut.
Signed-off-by: Xinye Tao <xinye.tao@metabit-trading.com>
caspermeijn
approved these changes
Mar 28, 2025
Contributor
|
Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://doc.rust-lang.org/edition-guide/rust-2024/match-ergonomics.html
The direct impact of this is, some prost structs are modded in our codebase by (1) use cargo-expand to unfold prost implementation (2) use script to replace certain types. After upgrading to edition-2024 the output from (1) triggers complaint from rust.