Skip to content

Add monitoring (logs) for missing messages (overload)#318

Merged
tolik518 merged 1 commit intotolik518:masterfrom
Aras14HD:monitor-disconnect
Feb 24, 2026
Merged

Add monitoring (logs) for missing messages (overload)#318
tolik518 merged 1 commit intotolik518:masterfrom
Aras14HD:monitor-disconnect

Conversation

@Aras14HD
Copy link
Collaborator

There have been repeatedly some comments factorion does not reply to for no discernable reason. This made me take the possibility of missing some comments, because the feeds are too fast.

This just adds some warns and logs for that and improves rechecking behavior.

@tolik518
Copy link
Owner

Looks good to me, thank you, I'll merge

@tolik518 tolik518 merged commit fab13d9 into tolik518:master Feb 24, 2026
6 checks passed
@tolik518
Copy link
Owner

tolik518 commented Feb 24, 2026

No comments. Requested comment (last_id or summon) is gone.

is kinda spammy right now, I have added a panel with the log filtered, maybe I'll remove it, as it appears not to be helpful

Edit: ok it's as spammy as "Polling Reddit for new comments..", which is ok, but level warn might be wrong, it should be info

@Aras14HD
Copy link
Collaborator Author

That shouldn't normally happen. That it does means, that we check summons and get not a single comment back.

Just checked and for some reason, we constantly have ids be Some, but empty, gonna fix that, that will also mean less requests used up per loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants