Add monitoring (logs) for missing messages (overload)#318
Merged
tolik518 merged 1 commit intotolik518:masterfrom Feb 24, 2026
Merged
Add monitoring (logs) for missing messages (overload)#318tolik518 merged 1 commit intotolik518:masterfrom
tolik518 merged 1 commit intotolik518:masterfrom
Conversation
Owner
|
Looks good to me, thank you, I'll merge |
Owner
|
is kinda spammy right now, I have added a panel with the log filtered, maybe I'll remove it, as it appears not to be helpful Edit: ok it's as spammy as "Polling Reddit for new comments..", which is ok, but level warn might be wrong, it should be info |
Collaborator
Author
|
That shouldn't normally happen. That it does means, that we check summons and get not a single comment back. Just checked and for some reason, we constantly have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been repeatedly some comments factorion does not reply to for no discernable reason. This made me take the possibility of missing some comments, because the feeds are too fast.
This just adds some warns and logs for that and improves rechecking behavior.