Skip to content

Add ModelFileGenerator and ModelFile for model data creation#18

Merged
tomasf merged 3 commits intotomasf:devfrom
iKenndac-forks:feature/custom-output-options
Feb 2, 2026
Merged

Add ModelFileGenerator and ModelFile for model data creation#18
tomasf merged 3 commits intotomasf:devfrom
iKenndac-forks:feature/custom-output-options

Conversation

@iKenndac
Copy link
Contributor

@iKenndac iKenndac commented Feb 1, 2026

This PR is a followup to issue #11, and the discussion in PR #12 and PR #14. Since PR #12 was getting quite stale in terms of its code and how dev is progressing, I decided to start fresh.

Continuing from this comment from @tomasf:

Thanks for the sketch - I have no meaningful objection to any of it. In this PR, I've taken that directly and:

  • Changed Generator and Product to ModelFileGenerator and ModelFile, but honestly I'm not that strongly opinionated. Maybe ProductGenerator and Product.

  • Added suggestedFileName to ModelFile.

  • Added some basic tests.

If you're happy with this, I suggest that I add documentation for the new stuff and adjust the documentation for Model slightly to discuss how it's distinct from this before merging.

@iKenndac iKenndac changed the base branch from main to dev February 1, 2026 14:02
Copy link
Owner

@tomasf tomasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I don't have strong opinions about naming either, but I think ModelFile better communicates what it's about than Product.

@iKenndac
Copy link
Contributor Author

iKenndac commented Feb 1, 2026

OK great! Give me a little bit to add some documentation and we can get this merged.

Thank you for the discussion along the way and the work you put in.

@iKenndac
Copy link
Contributor Author

iKenndac commented Feb 2, 2026

@tomasf Alright, here you go. I also added a static build() function for slightly easier one-shot building, and documented everything. Please give the docs a once-over, but I think it's OK.

@tomasf tomasf merged commit 0bb77f2 into tomasf:dev Feb 2, 2026
@tomasf
Copy link
Owner

tomasf commented Feb 2, 2026

Looks great. Thanks for all the work on this, and for sticking with the design discussion as it evolved. I’m very happy with the end result. I really appreciate your patience and the care you put into this. Thank you for helping make Cadova better!

I’ll be making a new release soon that includes this, along with a minor fix for colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants